<div dir="ltr">Hi Mark,<div class="gmail_extra"><br><br><div class="gmail_quote">On 5 February 2014 16:45, Mark Gergely <span dir="ltr"><<a href="mailto:gergely.mark@sztaki.mta.hu" target="_blank">gergely.mark@sztaki.mta.hu</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">Dear All,<div><br></div>

<div>I believe that there is a bug with handling of the :describe_with_terminated_instances: econe server configuration variable. The variable gets evaluated in the include_terminated_instances? method (instance.rb file). The method works like this: @config[:describe_with_terminated_instances] || DESCRIBE_WITH_TERMINATED_INSTANCES, but the second constant is always true, therefore the config parameter won’t affect the return value, it will always be true.</div>

<div>I think that the second constant is useless and it should be removed.</div><div>also there is a spare equal mark in the default config file: :describe_with_terminated_instances: <b>=</b> true</div></div></blockquote>

<div><br></div><div>You are right it is a bug. The constant is there in case you are using an old conf file, to be included by default. It should look like this:</div><div><br></div><div>diff --git a/src/cloud/ec2/etc/econe.conf b/src/cloud/ec2/etc/econe.conf</div>

<div>index d9c2e59..1114d09 100644</div><div>--- a/src/cloud/ec2/etc/econe.conf</div><div>+++ b/src/cloud/ec2/etc/econe.conf</div><div>@@ -65,7 +65,7 @@</div><div> #:datastore_id:</div><div><br></div><div> # Include terminated instances in the describe_instances xml</div>

<div>-:describe_with_terminated_instances: = true</div><div>+:describe_with_terminated_instances: true</div><div> # Terminated VMs will be included in the list</div><div> #  till the termination date + TERMINATED_INSTANCES_EXPIRATION_TIME is reached</div>

<div> :terminated_instances_expiration_time: 900</div><div>diff --git a/src/cloud/ec2/lib/instance.rb b/src/cloud/ec2/lib/instance.rb</div><div>index 179616d..1d069a8 100644</div><div>--- a/src/cloud/ec2/lib/instance.rb</div>

<div>+++ b/src/cloud/ec2/lib/instance.rb</div><div>@@ -340,7 +340,11 @@ module Instance</div><div>     end</div><div><br></div><div>     def include_terminated_instances?</div><div>-        @config[:describe_with_terminated_instances] || DESCRIBE_WITH_TERMINATED_INSTANCES</div>

<div>+        if @config[:describe_with_terminated_instances].nil?</div><div>+            DESCRIBE_WITH_TERMINATED_INSTANCES</div><div>+        else</div><div>+            @config[:describe_with_terminated_instances]</div>

<div>+        end</div><div>     end </div><div><br></div><div>Thank you for your feedback</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div style="word-wrap:break-word"><div><br></div><div>All the best,</div><div>Mark Gergely</div><div>MTA SZTAKI LPDS</div></div><br>_______________________________________________<br>
Users mailing list<br>
<a href="mailto:Users@lists.opennebula.org">Users@lists.opennebula.org</a><br>
<a href="http://lists.opennebula.org/listinfo.cgi/users-opennebula.org" target="_blank">http://lists.opennebula.org/listinfo.cgi/users-opennebula.org</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div>--<br></div>Daniel Molina<br>Project Engineer<br>OpenNebula - Flexible Enterprise Cloud Made Simple<br><a href="http://www.OpenNebula.org" target="_blank">www.OpenNebula.org</a> | <a href="mailto:dmolina@opennebula.org" target="_blank">dmolina@opennebula.org</a> | @OpenNebula</div>


</div></div>